Skip to content

Fix "readlink" Run on Paths That Contain Spaces #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

rogerluan
Copy link
Contributor

Checklist

  • I've read the Contribution Guidelines
  • I've run bundle exec rspec from the root directory to run my changes against rspec tests
  • I've run bundle exec rubocop to check code style

I honestly haven't even cloned the repo, this is a #trivial fix.

Description

Resolves #49
This PR is an equivalent to leavez/cocoapods-binary#107, since this code uses cocoapods-binary internally.

This issue has also been reported CocoaPods/CocoaPods#10298 (although it's not related to CocoaPods, but cocoapods-binary only).

@rogerluan rogerluan changed the title Fix "readlink" run on paths that contain spaces. Fix "readlink" Run on Paths That Contain Spaces Feb 16, 2021
@ivanrnld ivanrnld merged commit 6d0d65f into grab:master Feb 16, 2021
@trinhngocthuyen
Copy link
Contributor

👍 Thanks for the PR!

@rogerluan rogerluan deleted the patch-1 branch February 16, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CP] Embed Pods Frameworks fails when Archiving
3 participants